Re: [PATCH 02/16] MIPS: ar231x: add basic AR5312 SoC support

[Jonas Gorski <jogo@xxxxxxxxxxx>]

On Sun, Sep 28, 2014 at 8:33 PM, Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx> wrote:
> Add basic support for Atheros AR5312/AR2312 SoCs: registers definition
> file and initial setup code.

For the whole file: please use the style

do_foo()
{
  if (is_ar5312())
      ar5312_foo();
}

instead of

do_foo()
{
  ar5312_foo();
}

ar5312_foo()
{
  if (!is_ar5312())
    return;
}

also same comments regarding naming (ar531x instead of ar5312).

Regards
Jonas