On Wed, Jul 23, 2014 at 4:58 PM, David Laight <David.Laight@xxxxxxxxxx> wrote: > From: Manuel Lauss >> Move the register offsets and bit descriptions from the au1000.h header >> to their only user, the au1000_eth.c driver. > > Personally I'd use 2 header files. > One for the private data and one for the public data. > It can be much easier to read code if the structure definitions are in > a header file. au1000.h now only contains core chip-specific code; this is the last driver which has driver-specific definitions living in the "chip-global" headers. Eventually I'd like to get rid of au1000_eth.h as well :) Manuel
