[PATCH 12/12] MIPS: CPC: use __raw_ memory access functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The CPC registers use native endianness, so using plain readl & writel
will produce incorrect results on big endian systems.

Reported-by: Jeffrey Deans <jeffrey.deans@xxxxxxxxxx>
Reported-by: Keng Koh <keng.koh@xxxxxxxxxx>
Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx>
---
Feel free to apply as a fixup for "MIPS: Add CPC probe, access
functions".
---
 arch/mips/include/asm/mips-cpc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/include/asm/mips-cpc.h b/arch/mips/include/asm/mips-cpc.h
index fb78935..988507e 100644
--- a/arch/mips/include/asm/mips-cpc.h
+++ b/arch/mips/include/asm/mips-cpc.h
@@ -75,13 +75,13 @@ static inline bool mips_cpc_present(void)
 #define BUILD_CPC_R_(name, off) \
 static inline u32 read_cpc_##name(void)				\
 {								\
-	return readl(mips_cpc_base + (off));			\
+	return __raw_readl(mips_cpc_base + (off));		\
 }
 
 #define BUILD_CPC__W(name, off) \
 static inline void write_cpc_##name(u32 value)			\
 {								\
-	writel(value, mips_cpc_base + (off));			\
+	__raw_writel(value, mips_cpc_base + (off));		\
 }
 
 #define BUILD_CPC_RW(name, off)					\
-- 
1.8.5.3



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux