On 14/03/06, Markos Chandras wrote:
> Hi Richard,
Hi Markos,
> On 03/05/2014 09:27 PM, Richard Guy Briggs wrote:
> >Each arch that supports audit requires syscall_get_arch() to able to log and
> >identify architecture-dependent syscall numbers. The information is used in at
> >least two different subsystems, so standardize it in the same call across all
> >arches.
> >
> >Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> >
> >---
> >diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
> >index 81c8913..41ecde4 100644
> >--- a/arch/mips/include/asm/syscall.h
> >+++ b/arch/mips/include/asm/syscall.h
> >@@ -103,7 +103,7 @@ extern const unsigned long sysn32_call_table[];
> >
> > static inline int __syscall_get_arch(void)
> > {
> >- int arch = EM_MIPS;
> >+ int arch = AUDIT_ARCH_MIPS;
> > #ifdef CONFIG_64BIT
> > arch |= __AUDIT_ARCH_64BIT;
> > #endif
> >@@ -113,4 +113,10 @@ static inline int __syscall_get_arch(void)
> > return arch;
> > }
> >
> >+static inline int syscall_get_arch(struct task_struct *task,
> >+ struct pt_regs *regs)
> >+{
> >+ return __syscall_get_arch();
> >+}
> >+
> > #endif /* __ASM_MIPS_SYSCALL_H */
>
> This is already fixed for MIPS
>
> http://patchwork.linux-mips.org/patch/6398/
>
> The code is in linux-next targeting 3.15 as far as I can tell.
Ok, good to see that it is pretty much the same approach.
My patchset is based on 3.13 (as I assume this patch is), so that
conflict will be sorted out once I add to linux-next...
> markos
- RGB
--
Richard Guy Briggs <rbriggs@xxxxxxxxxx>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
