On 14-01-27 10:13 PM, Benjamin Herrenschmidt wrote: > On Wed, 2014-01-22 at 19:38 -0500, Paul Gortmaker wrote: > >> Thanks, it was a great help as it uncovered a few issues in fringe arch >> that I didn't have toolchains for, and I've fixed all of those up. >> >> I've noticed that powerpc has been un-buildable for a while now; I have >> used this hack patch locally so I could run the ppc defconfigs to check >> that I didn't break anything. Maybe useful for linux-next in the >> interim? It is a hack patch -- Not-Signed-off-by: Paul Gortmaker. :) > > Can you and/or Aneesh submit that as a proper patch (with S-O-B > etc...) ? I'd updated toolchains and didn't realize it was still broken. Patch sent. http://patchwork.ozlabs.org/patch/314749/ Paul. -- > > Thanks ! > > Cheers, > Ben. > >> Paul. >> -- >> >> diff --git a/arch/powerpc/include/asm/pgtable-ppc64.h b/arch/powerpc/include/asm/pgtable-ppc64.h >> index d27960c89a71..d0f070a2b395 100644 >> --- a/arch/powerpc/include/asm/pgtable-ppc64.h >> +++ b/arch/powerpc/include/asm/pgtable-ppc64.h >> @@ -560,9 +560,9 @@ extern void pmdp_invalidate(struct vm_area_struct *vma, unsigned long address, >> pmd_t *pmdp); >> >> #define pmd_move_must_withdraw pmd_move_must_withdraw >> -typedef struct spinlock spinlock_t; >> -static inline int pmd_move_must_withdraw(spinlock_t *new_pmd_ptl, >> - spinlock_t *old_pmd_ptl) >> +struct spinlock; >> +static inline int pmd_move_must_withdraw(struct spinlock *new_pmd_ptl, >> + struct spinlock *old_pmd_ptl) >> { >> /* >> * Archs like ppc64 use pgtable to store per pmd >> >> _______________________________________________ >> Linuxppc-dev mailing list >> Linuxppc-dev@xxxxxxxxxxxxxxxx >> https://lists.ozlabs.org/listinfo/linuxppc-dev > >
