2014/1/15 Florian Fainelli <florian@xxxxxxxxxxx>: > 2014/1/15 David Daney <ddaney@xxxxxxxxxxxxxxxxxx>: >> On 01/15/2014 11:06 AM, Florian Fainelli wrote: >>> >>> Attempting to build for Cavium Octeon with an unpatched or old >>> toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized. >>> Call cc-option on this option to make sure we can safely use it. >>> >>> Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx> >> >> >> NACK. >> >> If the chip you are building for needs -Wa,-mfix-cn63xxp1, then building >> without this option yields a system the generates random errors. So I would >> argue that if -Wa,-mfix-cn63xxp1 is not supported by your assembler, >> breaking the build is the proper thing to do. > > Fair enough. Maybe the condition should be refined to be based off > CONFIG_CAVIUM_CN63XXP1? Which is already the case... sorry for the noise. -- Florian
