On 01/15/2014 11:06 AM, Florian Fainelli wrote:
Attempting to build for Cavium Octeon with an unpatched or old
toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
Call cc-option on this option to make sure we can safely use it.
Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx>
NACK.
If the chip you are building for needs -Wa,-mfix-cn63xxp1, then building
without this option yields a system the generates random errors. So I
would argue that if -Wa,-mfix-cn63xxp1 is not supported by your
assembler, breaking the build is the proper thing to do.
David Daney
---
arch/mips/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 873a0ca..f372b84 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -155,7 +155,7 @@ cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += $(call cc-option,-march=octeon) -Wa,--trap
ifeq (,$(findstring march=octeon, $(cflags-$(CONFIG_CPU_CAVIUM_OCTEON))))
cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += -Wa,-march=octeon
endif
-cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,-mfix-cn63xxp1
+cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,$(call cc-option,-mfix-cn63xxp1)
cflags-$(CONFIG_CPU_BMIPS) += -march=mips32 -Wa,-mips32 -Wa,--trap
cflags-$(CONFIG_CPU_R4000_WORKAROUNDS) += $(call cc-option,-mfix-r4000,)
