On Thu, Jun 20, 2013 at 10:36:30AM -0500, Steven J. Hill wrote: > From: Leonid Yegoshin <Leonid.Yegoshin@xxxxxxxxxx> > > This reverts commit 3f4579252aa166641861a64f1c2883365ca126c2. It is > invalid because the macros CAC_ADDR and UNCAC_ADDR have a kernel > virtual address as an argument and also returns a kernel virtual > address. Using and physical address PHYS_OFFSET is blatantly wrong > for a macro common to multiple platforms. While the patch itself is looking sane at a glance, I'm wondering if this is fixing any actual bug or is just the result of a code review? Ralf
