On Fri, Jun 21, 2013 at 07:03:01PM +0800, Tony Wu wrote: > arch/mips/include/asm/cpu-features.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/include/asm/cpu-features.h b/arch/mips/include/asm/cpu-features.h > index e5ec8fc..df5e523 100644 > --- a/arch/mips/include/asm/cpu-features.h > +++ b/arch/mips/include/asm/cpu-features.h > @@ -136,7 +136,9 @@ > #endif > #endif > > +#ifndef cpu_has_mips_1 > # define cpu_has_mips_1 (cpu_data[0].isa_level & MIPS_CPU_ISA_I) > +#endif cpu_has_mips_1 will always evaluate as MIPS I because later ISA revisions always contain MIPS I as a subset. So maybe we should rather remove cpu_has_mips_1 and MIPS_CPU_ISA_I entirely. The sole user of cpu_has_mips_1, proc.c could easily be cleaned up, the sole test for MIPS_CPU_ISA_I in traps.c is slightly more work to clean up because it really is a test for the cp0 architecture. Ralf
