Re: [PATCH] MIPS: define cpu_has_mmips where appropriate

[David Daney <ddaney.cavm@xxxxxxxxx>]

On 05/24/2013 09:20 AM, David Daney wrote:
> On 05/23/2013 02:42 PM, Jonas Gorski wrote:
> > Disable cpu_has_mmips for everything but SEAD3 and MALTA. Most of these
> > platforms are from before the micromips introduction, so they are very
> > unlikely to implement it.
> >
> > Reduces an -Os compiled, uncompressed kernel image by 8KiB for BCM63XX.
> >
> > Signed-off-by: Jonas Gorski <jogo@xxxxxxxxxxx>
>
> Acked-by: David Daney <david.daney@xxxxxxxxxx>

I changed my mind:  NAK.

I will send a smaller, but equivalent patch.


> > ---
> >
> > Position chosen is based on asm/cpu-features.h. Missing hardware and/or
> > data sheets for most platforms I obviously couldn't verify its
> > non-existence, so maintainer acks are appreciated.
> >
> >   arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-bcm63xx/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-cobalt/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-ip22/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-ip28/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-ip32/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-loongson/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-pmcs-msp71xx/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-powertv/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-ralink/rt288x/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-ralink/rt305x/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-ralink/rt3883/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-rc32434/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-rm/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-sibyte/cpu-feature-overrides.h
> > |    1 +
> >   arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h
> > |    1 +
> >   21 files changed, 21 insertions(+)
> [...]