On Wed, 8 May 2013, David Daney wrote: > > > You don't really explain how the change helps optimization either. > > > > > The exercise is left to the reader. Build a microMIPS kernel yourself and > > figure it out. > > This isn't some sort of programming text book. Your job in the change log > (and the mailing list) isn't to force us to learn by doing a lot of > independent analysis of the code. Instead I would prefer a concise > explanation of why the change is beneficial. > > You are dumping a lot of new code into the kernel. That is fine, but you > could consider making the process easier by improving the quality of the > changelogs that accompany it. I concur, it's the contributor's responsibility to make the reviewers' work as easy as possible and to convince them that the change offered is both technically correct and desired for inclusion. Maciej
