Re: [PATCH v99,11/13] MIPS: microMIPS: Optimise 'strncpy' core library function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/07/2013 06:01 PM, David Daney wrote:
> On 12/06/2012 09:05 PM, Steven J. Hill wrote:
>> From: "Steven J. Hill" <sjhill@xxxxxxxx>
>> 
>> Optimise 'strncpy' to use microMIPS instructions and/or optimisations for
>> binary size reduction. When the microMIPS ISA is not being used, the
>> library function compiles to the original binary code.
> 
> This is an untrue statement.  Why mislead us by saying the original binary
> code is obtained?
> 
I you are building a classic MIPS kernel, the instructions generated will be
the same even with this patch. The changes only make a difference when
building a pure microMIPS kernel.

> You don't really explain how the change helps optimization either.
> 
The exercise is left to the reader. Build a microMIPS kernel yourself and
figure it out.

- -Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlGJxBcACgkQgyK5H2Ic36c4hQCeLGI8MI2rr6KgOv7G15lnBdok
bbcAoKY+BvVyTCzG033Bc+pJ07xCtGMq
=xJmM
-----END PGP SIGNATURE-----


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux