2013.04.12. 13:19 keltezéssel, John Crispin írta: > On 12/04/13 13:12, Gabor Juhos wrote: >> The commit log says that the code registers the pinmux settings. However the >> patch only contains the definitions of the pinmux groups without doing anything >> with those. Additionally, the structures and the 'rt288x_wdt_reset' function >> should be static. >> >> However converting them to static would cause compiler warnings about unused >> variables/functions. So it would be simpler to remove these. You have removed >> the pinmux driver from the series anyway, and this part can't be used without >> that. > > > the same was done for rt305x and causes no harm, so I really don't see a problem > with adding these now. You are right, it causes no harm explicitly. Simply it adds dead code which will be built into the kernel and it will never run. > i will address the "static" bit for the next series Don't bother with that. Adding static declaration for unused variables/functions give us nothing but compiler warnings. -Gabor
