On Tue, 2013-03-05 at 13:55 +0100, Jonas Gorski wrote: > On 5 March 2013 13:20, Paul Bolle <pebolle@xxxxxxxxxx> wrote: > > diff --git a/arch/mips/include/asm/mach-sead3/cpu-feature-overrides.h b/arch/mips/include/asm/mach-sead3/cpu-feature-overrides.h > > index d9c8284..b40f37f 100644 > > --- a/arch/mips/include/asm/mach-sead3/cpu-feature-overrides.h > > +++ b/arch/mips/include/asm/mach-sead3/cpu-feature-overrides.h > > @@ -28,11 +28,7 @@ > > /* #define cpu_has_prefetch ? */ > > #define cpu_has_mcheck 1 > > /* #define cpu_has_ejtag ? */ > > -#ifdef CONFIG_CPU_HAS_LLSC > > -#define cpu_has_llsc 1 > > -#else > > #define cpu_has_llsc 0 > > -#endif > > Hm, shouldn't you leave cpu_has_llsc set to 1? At least the "old" path > SEAD3 => CPU_MIPS32_R1/R2/64_R1 => select CPU_HAS_LLSC for all three > would have always caused this to be 1. That would mean an actual change to the code. See, there's no Kconfig symbol CPU_HAS_LLSC since v2.6.32. This means that CONFIG_CPU_HAS_LLSC has not been defined ever since and that SEAD3 has been having cpu_has_llsc set to 0 for some time now. My patch just removes dead code. Perhaps SEAD3 need cpu_has_llsc set to 1. I wouldn't know. Anyhow, that should be done in another patch, with (runtime) testing, etc. Paul Bolle
