Re: [PATCH] MIPS: Remove redundant TLB invalidate from pmdp_splitting_flush().

[Ralf Baechle <ralf@xxxxxxxxxxxxxx>]

On Wed, Oct 17, 2012 at 05:20:20PM -0700, David Daney wrote:

> diff --git a/arch/mips/mm/pgtable-64.c b/arch/mips/mm/pgtable-64.c
> index 6c9a477..5408bb5 100644
> --- a/arch/mips/mm/pgtable-64.c
> +++ b/arch/mips/mm/pgtable-64.c
> @@ -71,7 +71,7 @@ void pmdp_splitting_flush(struct vm_area_struct *vma,
>  	if (!pmd_trans_splitting(*pmdp)) {
>  		pmd_t pmd = pmd_mksplitting(*pmdp);
>  		set_pmd_at(vma->vm_mm, address, pmdp, pmd);
> -		flush_tlb_range(vma, address, address + HPAGE_SIZE);
> +		/* TLB already flushed by set_pmd_at() */

Thanks, folded into the THP patch.

  Ralf