On 09/05/2012 03:32 PM, Jim Quinlan wrote:
This is V4 of my submission. Here is a list of requested changes:
o Extra commit was added for changing an unsigned short to an int.
o Use of EXTERN_SYMBOL was added to mips-atomic.c and bitops.c,
as well as the removal of 'extern' in the functions' declarations.
o Name of funcs changed from atomic_xxx to __mips_xxx in bitops.c.
o The function comments in bitops.c were tweaked to please
scripts/kernel-doc.
Here is a list of requested changes that were not done (and why):
o Suggested optimization of _MIPS_SZLONG and others was not needed
as mips-atomic.c now includes <asm/irqflags.h>.
o Suggested fixes to please checkpatch.pl for whitespace before
newlines in asm strings was attempted but the result made the
assembly code look more cluttered => no change made.
These were unrequested changes:
o Changed order of func listings in irqflags.h so that only one
#ifdef/#endif pair was needed instead of three.
Jim Quinlan
FWIW: I haven't tested these, but...
Acked-by: David Daney <david.daney@xxxxxxxxxx>
Thanks for your patience,
David Daney
