2012/8/31 Hauke Mehrtens <hauke@xxxxxxxxxx>: > +u32 bcma_gpio_in(struct bcma_bus *bus, u32 mask) > +{ > + unsigned long flags; > + u32 res = 0; > + > + spin_lock_irqsave(&bus->gpio_lock, flags); > + res = bcma_chipco_gpio_in(&bus->drv_cc, mask); > + spin_unlock_irqrestore(&bus->gpio_lock, flags); > + > + return res; > +} > +EXPORT_SYMBOL(bcma_gpio_in); Could we put here direct ops on ChipCommon regs and drop GPIO functions from driver_chipcommon.c? -- Rafał