On Sun, Sep 02, 2012 at 10:27:37PM +0200, Lars-Peter Clausen wrote: > On 09/02/2012 10:21 PM, Thierry Reding wrote: > > On Sun, Sep 02, 2012 at 04:45:43PM +0200, Lars-Peter Clausen wrote: > >> On 09/02/2012 11:52 AM, Thierry Reding wrote: > >>> This is a prerequisite for allowing the PWM driver to be converted to > >>> the PWM framework. > >>> > >>> Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> > >> > >> I'd prefer to keep the timer functions inline, some of them are called quite > >> often in the system clock code. > > > > I've opted for this variant because it better hides the register values. > > If the functions are inlined it also means the complete register > > definitions need to go into timer.h. If you don't think that's an issue, > > I can update the patch accordingly. > > > > It's not pretty, but it should be ok. Having a single global function for each > and every register access is kind of ugly too. Okay, I'll update the patch accordingly. I probably won't get around to it until later this week because I won't have access to a computer for a few days but I'll be back at work on September 10 and should be able to send the next version of this series out then. Thierry
Attachment:
pgpiFq9HWmU1C.pgp
Description: PGP signature
