On 21/08/12 20:33, David Daney wrote: > On 08/21/2012 11:23 AM, John Crispin wrote: >> On 11/05/12 23:34, David Daney wrote: >>> From: David Daney <david.daney@xxxxxxxxxx> >>> >>> Add the driver, link it into the kbuild system and provide device tree >>> binding documentation. >>> >>> Signed-off-by: David Daney <david.daney@xxxxxxxxxx> >> >> Thanks, queued for 3.7. >> > > This cannot go in like this. > > There were a bunch of requests by other maintainers that were never > done. Also since it is in a foreign subsystem, it at a minimum needs > some additional Acked-bys hmmm ... you are right about the Acked-by ... i forgot to merge add it ... i did ask you about this on IRC and you said the driver was ok to be merged like this. inside the thread linus wllej at some point says that his comment was bogus if i am not mistaken ? John