On Tue, 14 Aug 2012 17:13:45 +0200, Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote: > Fixes build failure introduced by "Make most arch asm/module.h files use > asm-generic/module.h" by moving all the RELA processing code to a > separate file to be used only for RELA processing on 64-bit kernels. > > CC arch/mips/kernel/module.o > arch/mips/kernel/module.c:250:14: error: 'reloc_handlers_rela' defined but not > used [-Werror=unused-variable] > cc1: all warnings being treated as errors > > make[6]: *** [arch/mips/kernel/module.o] Error 1 > > Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > > --- > This is bigger than Jonas' suggested patch but far less #ifdefy. > A minimal fix would be to add __maybe_unused to the definition of > reloc_handlers_rela but imho __maybe_unused should be avoided where > possible. > > I tested this on top of today's -next but ideally to keep bisectability > it should be applied early in the series before CONFIG_MODULES_USE_ELF_RELA > is introduced which would require trivial tweaking arch/mips/kernel/Makefile > tweaking. OK, as suggested, applied as a separate patch (with a bit of tweaking), and then modified David's patch to flip the condition in the Makefile. This will sit in linux-next another cycle. Cheers, Rusty.
