Hi John, On Thu, Aug 16, 2012 at 2:32 PM, John Crispin <blogic@xxxxxxxxxxx> wrote: > Hi Shubhrajyoti, > > Thanks for the comments, I just noticed that clk_put() is also missing > and that the clock gate should be deactivated upon a rmmod ... i will > fix all of these and resend the patch. There are two things 1> Relinquishing the handle. I think clk_put does that not sure. 2> Gating , ie deactivating the clock the best place for this to happen is when there is no transfer. However that aggression in PM can happen later. > > John