Hi Kevin, On 23 June 2012 07:14, Kevin Cernekee <cernekee@xxxxxxxxx> wrote: > The "IUDMA" engine used by bcm63xx_enet is also used by other blocks, > such as the USB 2.0 device. Move the definitions into a common file so > that they do not need to be duplicated in each driver. If it's common, maybe then it shouldn't be in bcm63xx_dev_enet.h but something like bcm63xx_iudma.h, and the struct also renamed to something generic (iudma_desc or so). Regards, Jonas