Thanks, I'll follow your suggestions. On Tue, Jun 19, 2012 at 3:56 PM, Michel Dänzer <michel@xxxxxxxxxxx> wrote: > On Die, 2012-06-19 at 14:50 +0800, Huacai Chen wrote: >> 1, Use 32-bit DMA as a workaround (Loongson has a hardware bug that it >> doesn't support DMA address above 4GB). >> 2, Read vga bios offered by system firmware. >> 3, Handle io prot correctly for MIPS. >> 4, Don't use swiotlb on Loongson machines (when use swiotlb, GPU reset >> occurs at resume from suspend). > > Sounds like this should be split up into smaller patches. > > >> diff --git a/include/drm/drm_sarea.h b/include/drm/drm_sarea.h >> index ee5389d..1d1a858 100644 >> --- a/include/drm/drm_sarea.h >> +++ b/include/drm/drm_sarea.h >> @@ -37,6 +37,8 @@ >> /* SAREA area needs to be at least a page */ >> #if defined(__alpha__) >> #define SAREA_MAX 0x2000U >> +#elif defined(__mips__) >> +#define SAREA_MAX 0x4000U >> #elif defined(__ia64__) >> #define SAREA_MAX 0x10000U /* 64kB */ >> #else > > Also, this change doesn't seem to be accounted for in the commit log. > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Debian, X and DRI developer