Hello.
On 06-06-2012 1:19, Steven J. Hill wrote:
From: "Steven J. Hill"<sjhill@xxxxxxxx>
Make headers consistent across the files
It's the case where you don't do it (forgot? :-).
and make changes based on running the checkpatch script.
Signed-off-by: Steven J. Hill<sjhill@xxxxxxxx>
---
arch/mips/lasat/prom.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/arch/mips/lasat/prom.c b/arch/mips/lasat/prom.c
index 8bd3994..0091351 100644
--- a/arch/mips/lasat/prom.c
+++ b/arch/mips/lasat/prom.c
@@ -2,19 +2,18 @@
* PROM interface routines.
*/
#include<linux/types.h>
-#include<linux/init.h>
No, it should be left intact because '__init' is used.
#include<linux/string.h>
#include<linux/ctype.h>
-#include<linux/kernel.h>
Doesn't the code use printk()?
@@ -58,7 +57,7 @@ static void setup_prom_vectors(void)
__prom_putc = (void *)PROM_PUTC_ADDR;
prom_monitor = (void *)PROM_MONITOR_ADDR;
}
- printk(KERN_DEBUG "prom vectors set up\n");
+ pr_debug("prom vectors set up\n");
Changes behavior: now you need to #define DEBUG at the start of file for
anything to be printed here.
WBR, Sergei
