On Sat, 19 May 2012 23:54:36 -0600, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
> On Fri, 11 May 2012 15:05:21 -0700, David Daney <ddaney.cavm@xxxxxxxxx> wrote:
> > From: David Daney <david.daney@xxxxxxxxxx>
> >
> > When generating MODALIASes, it is convenient to add things like "spi:"
> > or "i2c:" to the front of the strings. This allows the standard
> > modprobe to find the right driver when automatically populating bus
> > children from the device tree structure.
> >
> > Add a prefix parameter, and adjust callers. For
> > of_register_spi_devices() use the "spi:" prefix.
> >
> > Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
>
> Applied, thanks. Some notes below...
Wait... why is this necessary? The module type prefix isn't stored in
the modalias value for any other bus type as far as I can see, and
with this series it appears that the "spi:" prefix may or may not be
present in the modalias. That doesn't look right.
Why isn't prefixing spi: at uevent time sufficient? IIUC, modprobe
depends on either UEVENT or the modalias attribute to know which
driver to probe. It does look like the attribute is missing the spi:
prefix though. Does the following change work instead of these two
patches?
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 3d8f662..da8aac7 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -51,7 +51,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf)
{
const struct spi_device *spi = to_spi_device(dev);
- return sprintf(buf, "%s\n", spi->modalias);
+ return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias);
}
So, I've dropped this patch from my tree. If the change above works
for you then I'll push it out.
g.
