Hello. On 02/17/2012 07:47 PM, John Crispin wrote:
The comment doesn't match the essence of patch.
sorry
Why not just clk_get(&pdev->dev, NULL)?
WBR, Sergei
clk_get_sys uses the clkdev lookup table, which is added by this series.
clk_get() does the same, indirectly.
it makes the clock code consistent throughout the lantiq related files. we use clk connections other places, which we cannot reference with clk_get that easily
clkdev assumes you don't need to use connection ID if the clock is bound to be matched by device ID via the lookup table. clk_get() is a common case when using clkdev, that's why your use of clk_get_sys() stands out as something unusual. I'll have to have a look at your lookup tables...
John
WBR, Sergei
