>> +#define SOC_ID_VRX288 0x1C0 > > Use tabs to indent the value as above. > i would have expected checkpatch.pl to complain about this one ?! >> + } else if (ltq_is_vr9()) { > > Where is this defined? > was added around 3.1 with the rest of the soc detection code. you can find it in arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h thx, John