Hello. On 18-11-2011 1:57, David Daney wrote:
From: David Daney<david.daney@xxxxxxxxxx>
It was pointed out by David Rientjes that the dummy values for HPAGE_MASK and HPAGE_SIZE are quite unsafe. It they are inadvertently used with !CONFIG_HUGETLB_PAGE, compilation would succeed, but the resulting code would surly not do anything sensible. Place BUG() in the these dummy definitions, as we do in similar circumstances in other places, so any abuse can be easily detected. Since the only sane place to use these symbols when !CONFIG_HUGETLB_PAGE is on dead code paths, the BUG() cause any actual code to be emitted by the compiler.
You mean "doesn't cause"?
Cc: David Rientjes<rientjes@xxxxxxxxxx> Signed-off-by: David Daney<david.daney@xxxxxxxxxx>
WBR, Sergei