On Wed, Nov 16, 2011 at 03:28:14PM +0100, John Crispin wrote:
> diff --git a/arch/mips/pci/pci-lantiq.c b/arch/mips/pci/pci-lantiq.c
> index be1e1af..c001c5a 100644
> --- a/arch/mips/pci/pci-lantiq.c
> +++ b/arch/mips/pci/pci-lantiq.c
> @@ -70,28 +70,27 @@
>
> struct ltq_pci_gpio_map {
> int pin;
> - int alt0;
> - int alt1;
> + int mux;
> int dir;
> char *name;
> };
You could save some memory here by using a shorter data type
such as char. This is not the Alpha, no performance penalty for
using types smaller than int :)
> /* the pci core can make use of the following gpios */
> static struct ltq_pci_gpio_map ltq_pci_gpio_map[] = {
> - { 0, 1, 0, 0, "pci-exin0" },
> - { 1, 1, 0, 0, "pci-exin1" },
> - { 2, 1, 0, 0, "pci-exin2" },
> - { 39, 1, 0, 0, "pci-exin3" },
> - { 10, 1, 0, 0, "pci-exin4" },
> - { 9, 1, 0, 0, "pci-exin5" },
> - { 30, 1, 0, 1, "pci-gnt1" },
> - { 23, 1, 0, 1, "pci-gnt2" },
> - { 19, 1, 0, 1, "pci-gnt3" },
> - { 38, 1, 0, 1, "pci-gnt4" },
> - { 29, 1, 0, 0, "pci-req1" },
> - { 31, 1, 0, 0, "pci-req2" },
> - { 3, 1, 0, 0, "pci-req3" },
> - { 37, 1, 0, 0, "pci-req4" },
> + { 0, 2, 0, "pci-exin0" },
> + { 1, 2, 0, "pci-exin1" },
> + { 2, 2, 0, "pci-exin2" },
> + { 39, 2, 0, "pci-exin3" },
> + { 10, 2, 0, "pci-exin4" },
> + { 9, 2, 0, "pci-exin5" },
> + { 30, 2, 1, "pci-gnt1" },
> + { 23, 2, 1, "pci-gnt2" },
> + { 19, 2, 1, "pci-gnt3" },
> + { 38, 2, 1, "pci-gnt4" },
> + { 29, 2, 0, "pci-req1" },
> + { 31, 2, 0, "pci-req2" },
> + { 3, 2, 0, "pci-req3" },
> + { 37, 2, 0, "pci-req4" },
Can you use named initializers here?
{ .pin = 0, .mux = 2, .dir = 0, .name = "pci_exin0", },
...
Ralf
