On Thu, Nov 17, 2011 at 03:02:56PM +0100, Rene Bolldorf wrote: Queued for 3.3 but: > Subject: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs. (v2) Please don't put the (v2) at the end of the subject line but rather into the initial part with the square brackets like: Subject: [PATCH 1/2, v2] Initial PCI support for Atheros 724x SoCs. That's so software like git-am will automatically discard that when applying a patch. Your use of non-ASCII characters is not quite yet supported in patchwork, see: http://patchwork.linux-mips.org/patch/3019/ http://patchwork.linux-mips.org/patch/3020/ My surname's spelling is also suffering from ASCII brain damaged software ... > + switch (size) { > + case 1: > + addr = where & ~3; > + mask = 0xff000000 >> ((where % 4) * 8); > + tval = reg_read(ATH724X_PCI_DEV_BASE + addr); > + tval = tval & ~mask; > + *value = (tval >> ((4 - (where % 4))*8)); > + break; > + case 2: That's a very odd style of formatting. The Linux coding style (see Documentation/) wants the break keyword indented with the same number of tabs as the preceeding block. Anyway, I took care of that. Thanks, Ralf
