On Mon, Nov 7, 2011 at 8:07 PM, Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote: > > Hitting this one in a non-hugepage build of upstream-sfr: > > CC arch/mips/mm/gup.o > arch/mips/mm/gup.c:70:51: error: redefinition of ‘get_huge_page_tail’ > include/linux/mm.h:379:51: note: previous definition of ‘get_huge_page_tail’ was here > make[2]: *** [arch/mips/mm/gup.o] Error 1 > make[1]: *** [arch/mips/mm] Error 2 > make: *** [arch/mips] Error 2 > > I fixed this one up by removing the local definition of get_huge_page_tail > but you may want to re-test. > Hi Ralf, It is my fault. While preparing the patch, Andrea shared the function in parallel, and I missed his update in linux/mm.h. thp: share get_huge_page_tail() author Andrea Arcangeli <aarcange@xxxxxxxxxx> Wed, 2 Nov 2011 20:37:36 +0000 (13:37 -0700) committer Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> Wed, 2 Nov 2011 23:06:58 +0000 (16:06 -0700) commit b35a35b556f5e6b7993ad0baf20173e75c09ce8c Test will be rechecked soon, and thanks for your fixup. Best regards Hillf
