On Thu, Oct 13, 2011 at 12:16:27PM -0700, Victor Kamensky wrote: > Yes, it does make a lot of sense. Don't you think we need to do > EXPORT_SYMBOL for __compute_return_epc as well? So it could be used by > klms. > > Actually we have yet another copy of it in mips uprobes code, which > normally is built as klm, if we refactor and export __compute_return_epc > all three places could use the same function. Nothing wrong with exporting __compute_return_epc() as long as there are actually users of the exported symbol. So far it's only used from the kernel proper which is why it's not been exported. However I'd prefer it to be exported as EXPORT_SYMBOL_GPL(). Ralf
