On Mon, Sep 26, 2011 at 12:50:44PM -0700, David Daney wrote: > On 09/25/2011 06:08 PM, rongqing.li@xxxxxxxxxxxxx wrote: > >From: Roy.Li<rongqing.li@xxxxxxxxxxxxx> > > > >Icmp packets with wrong checksum are never dropped since > >skb->ip_summed is set to CHECKSUM_UNNECESSARY. > > > >When icmp packets with wrong checksum pass through the octeon > >net driver, the not_IP, IP_exc, L4_error hardware indicators > >show no error. so the driver sets CHECKSUM_UNNECESSARY on > >skb->ip_summed. > > > >L4_error only works for TCP/UDP, not for ICMP. > > > >Signed-off-by: Roy.Li<rongqing.li@xxxxxxxxxxxxx> > > We found the same problem, but have not yet sent the patch to fix it. > > This looks fine to me, > > Acked-by: David Daney <david.daney@xxxxxxxxxx> > > I would let davem, Ralf and Greg KH fight over who gets to merge it. I'll let Ralf take it, unless he wants me to. Ralf?
