On Thursday 22 September 2011 12:20:50 Sergei Shtylyov wrote:
> Hello.
>
> On 21-09-2011 17:39, Florian Fainelli wrote:
> > From: Florian Fainelli<ffainelli@xxxxxxxxxx>
> >
> > Instead of hardcoding the amount of available RAM, read the number of
> > effective multiples of 8MB from SDRAM_MBASE_REG.
> >
> > Signed-off-by: Florian Fainelli<florian@xxxxxxxxxxx>
> > ---
> >
> > arch/mips/bcm63xx/cpu.c | 6 ++++--
> > 1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/mips/bcm63xx/cpu.c b/arch/mips/bcm63xx/cpu.c
> > index 7c7e4d4..7ad1b39 100644
> > --- a/arch/mips/bcm63xx/cpu.c
> > +++ b/arch/mips/bcm63xx/cpu.c
> > @@ -260,8 +260,10 @@ static unsigned int detect_memory_size(void)
> >
> > unsigned int cols = 0, rows = 0, is_32bits = 0, banks = 0;
> > u32 val;
> >
> > - if (BCMCPU_IS_6345())
> > - return (8 * 1024 * 1024);
> > + if (BCMCPU_IS_6345()) {
> > + val = bcm_sdram_readl(SDRAM_MBASE_REG);
> > + return (val * 8 * 1024 * 1024);
>
> Parens not needed here.
For consistency with other parts of the code, I would rather keep it.
--
Florian
