On 09/14/2011 05:51 PM, Grant Likely wrote:
On Aug 31, 2011 2:01 PM, "David Daney" <david.daney@xxxxxxxxxx
<mailto:david.daney@xxxxxxxxxx>> wrote:
>
> This patch adds a somewhat generic framework for MDIO bus
> multiplexers. It is modeled on the I2C multiplexer.
>
[...]
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/mdio-mux.txt
> @@ -0,0 +1,132 @@
> +Common MDIO bus multiplexer/switch properties.
> +
> +An MDIO bus multiplexer/switch will have several child busses that are
> +numbered uniquely in a device dependent manner. The nodes for an MDIO
> +bus multiplexer/switch will have one child node for each child bus.
> +
> +Required properties:
> +- parent-bus : phandle to the parent MDIO bus.
As discussed, I like mdio-parent-bus.
> +
> +Optional properties:
> +- Other properties specific to the multiplexer/switch hardware.
> +
> +Required properties for child nodes:
> +- #address-cells = <1>;
> +- #size-cells = <0>;
> +- cell-index : The sub-bus number.
Use reg, not cell-index. That is what it is there for. And add the
appropriate #address/size-cells in the parent.
I've not reviewed the implementation, but with the changes. I'm okay
with the binding.
Thanks for the prompt reply Grant.
I will rework this with the binding changes and send a new version soon.
David Daney
