2011/8/25 Bjorn Helgaas <bhelgaas@xxxxxxxxxx>:
> No, I just mean that I don't see why you need this patch at all. If
> you pass the list of bus resources to pci_create_bus(), there's no
> need to fix anything up later. Or am I missing something?
Well, doing the root resource fixups in here is a *paranoid* way. It's to
deal with the 'unlikely' circumstance where controller_resources() returns
the NULL pointer in pcibios_scanbus() due to memory allocation failure.
Most of the time (always) it's nothing more than repeating the resource
list setup. But maybe we can do something like this:
if (unlikely(!dev && list_empty(&bus->resources))
pcibios_setup_root_resources(bus, hose);
What do you think?
Deng-Cheng
