Hi, On 10 June 2011 23:47, Maxime Bizon <mbizon@xxxxxxxxxx> wrote: > diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h > index 3ea2681..4354be1 100644 > --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h > +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h > @@ -89,9 +89,18 @@ > > Â/* Interrupt Mask register */ > Â#define PERF_IRQMASK_REG Â Â Â Â Â Â Â 0xc > +#define PERF_IRQSTAT_REG Â Â Â Â Â Â Â 0x10 You are re-adding the duplicate PERF_IRQSTAT_REG I just removed. > +#define PERF_IRQMASK_6338_REG Â Â Â Â Â0xc > +#define PERF_IRQMASK_6345_REG Â Â Â Â Â0xc > +#define PERF_IRQMASK_6348_REG Â Â Â Â Â0xc > +#define PERF_IRQMASK_6358_REG Â Â Â Â Â0xc If you are adding one for each SoC, why keep the "generic" PERF_IRQMASK_REG at all? AFAICS it isn't used it any more. > > Â/* Interrupt Status register */ > Â#define PERF_IRQSTAT_REG Â Â Â Â Â Â Â 0x10 > +#define PERF_IRQSTAT_6338_REG Â Â Â Â Â0x10 > +#define PERF_IRQSTAT_6345_REG Â Â Â Â Â0x10 > +#define PERF_IRQSTAT_6348_REG Â Â Â Â Â0x10 > +#define PERF_IRQSTAT_6358_REG Â Â Â Â Â0x10 The same applies to the "generic" PERF_IRQSTAT_REG, you can also remove it. Jonas
