Hi, David, I am willing to get more feedback and sort out issues before I forgot all details. I post a simple testing program at http://www.linux-mips.org/archives/linux-mips/2011-05/msg00252.html And it was also tested in a real application using mmap heavily and need this patch to avoid failure. It is my bad to take your suggestion literally. How about arch_get_unmapped_area_common()? Thanks, Jian -----Original Message----- From: David Daney [mailto:ddaney@xxxxxxxxxxxxxxxxxx] Sent: Wednesday, May 25, 2011 10:58 AM To: Jian Peng Cc: linux-mips@xxxxxxxxxxxxxx; Ralf Baechle Subject: Re: patch to support topdown mmap allocation in MIPS On 05/25/2011 10:47 AM, Jian Peng wrote: > Hi, Ralf/David, > > What else should I do to get this patch merged? > Be patient. And tell how it was tested. Also .... [...] > + > +unsigned long arch_get_unmapped_area_foo(struct file *filp, unsigned long addr0, > + unsigned long len, unsigned long pgoff, unsigned long flags, > + enum mmap_allocation_direction dir) I know I suggested the name *_foo, but really I expected you to choose a better name, as the 'foo' is just the default name for examples. I think it needs a better name than that. I will try to test it on my Octeon system sometime. David Daney
