Hi Ralf,
On Fri, Mar 25, 2011 at 01:58:20PM +0100, Ralf Baechle wrote:
> On Fri, Mar 25, 2011 at 02:26:57PM +0300, Sergei Shtylyov wrote:
>
> > >+static inline void cpu_probe_netlogic(struct cpuinfo_mips *c, int cpu)
> > >+{
> > >+ decode_configs(c);
> > >+
> > >+ c->options = (MIPS_CPU_TLB |
> >
> > Perhaps should align | with others...
> >
> > >+ MIPS_CPU_4KEX |
> > >+ MIPS_CPU_COUNTER |
> > >+ MIPS_CPU_DIVEC |
> > >+ MIPS_CPU_WATCH |
> > >+ MIPS_CPU_EJTAG |
> > >+ MIPS_CPU_LLSC);
>
> I reformatted that.
>
> > [...]
> > >+ default:
> > >+ printk(KERN_INFO "Unknown Netlogic chip id [%02x]!\n",
> >
> > Not %04x?
>
> I changed this into a panic call. An unknown CPU type means very little
> chance for the system to actually succesfully boot the system.
>
> Queued for 2.6.39. Thanks,
Thanks!
I noticed that the commit messages for the patchset are messed up, it contains
part of the mail header too.
This is what I see in 'git log'
|commit 7271e23649991af8d70da576052312571b71dba3
|Author: Jayachandran C <jayachandranc@xxxxxxxxxxxxxxxxx>
|Date: Fri Mar 25 10:29:09 2011 +0530
|
| From jayachandranc@xxxxxxxxxxxxxxxxx Fri Mar 25 05:52:44 2011
| X-Spam-Checker-Version: SpamAssassin 3.3.2-r929478 (2010-03-31) on
| eddie.linux-mips.org
| X-Spam-Level:
| X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RDNS_NONE,
| UPPERCASE_75_100 autolearn=no version=3.3.2-r929478
Not sure what caused this, let me know if it was my fault.
Thanks,
JC.
