Re: [PATCH 1/7] Netlogic XLR/XLS processor IDs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 25, 2011 at 02:26:57PM +0300, Sergei Shtylyov wrote:

> >+static inline void cpu_probe_netlogic(struct cpuinfo_mips *c, int cpu)
> >+{
> >+	decode_configs(c);
> >+
> >+	c->options = (MIPS_CPU_TLB     |
> 
>    Perhaps should align | with others...
> 
> >+			MIPS_CPU_4KEX    |
> >+			MIPS_CPU_COUNTER |
> >+			MIPS_CPU_DIVEC   |
> >+			MIPS_CPU_WATCH   |
> >+			MIPS_CPU_EJTAG   |
> >+			MIPS_CPU_LLSC);

I reformatted that.

> [...]
> >+	default:
> >+		printk(KERN_INFO "Unknown Netlogic chip id [%02x]!\n",
> 
>    Not %04x?

I changed this into a panic call.  An unknown CPU type means very little
chance for the system to actually succesfully boot the system.

Queued for 2.6.39.  Thanks,

  Ralf



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux