Re: [patch 06/38] mips: dec: Convert to new irq_chip functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 24 Mar 2011, Ralf Baechle wrote:

> Thanks, queued for 2.6.39.

 Ralf, thanks for cc-ing me.

 NACK, where's the logic to ack IOASIC DMA IRQs gone?  The SIR has to be 
written as in clear_ioasic_irq() for the respective DMA transfer to resume 
and the interrupt in question be able to retrigger in the future.

 The rest is probably OK, but why has the inline hint been removed?  
These functions are simple, worth a couple of assembly instructions at 
most and used throughout these files, so it's good to ask GCC to inline 
them if worthwhile even if -fno-unit-at-a-time has been requested for 
whatever reason.

  Maciej



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux