Hi Florian, <...> >> + >> +static DEFINE_SPINLOCK(ath79_device_reset_lock); >> + >> +u32 ath79_cpu_freq; >> +EXPORT_SYMBOL_GPL(ath79_cpu_freq); >> + >> +u32 ath79_ahb_freq; >> +EXPORT_SYMBOL_GPL(ath79_ahb_freq); >> + >> +u32 ath79_ddr_freq; >> +EXPORT_SYMBOL_GPL(ath79_ddr_freq); > > Why not use the Clock API with fixed rates just like how it is done for AR7? Can you tell me the advantage of that? We can't modify the rates of these clocks, even we can't {en,dis}able them. Implementing the clock API would add an unnecessary wrapper layer around the current implementation in my opinion. Regards, Gabor