On 9/23/10, David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote: > On 09/21/2010 10:59 PM, wuzhangjin@xxxxxxxxx wrote: >> From: Wu Zhangjin<wuzhangjin@xxxxxxxxx> >> >> When EMBEDDED is disabled, the EARLY_PRINTK option will be hiden and we >> have no way to disable it. >> >> For EARLY_PRINTK is not necessary for !EMBEDDED, we should make it >> selectable and only enable it by default for EMBEDDED. >> >> Signed-off-by: Wu Zhangjin<wuzhangjin@xxxxxxxxx> >> --- >> arch/mips/Kconfig.debug | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug >> index 43dc279..77eba81 100644 >> --- a/arch/mips/Kconfig.debug >> +++ b/arch/mips/Kconfig.debug >> @@ -7,9 +7,9 @@ config TRACE_IRQFLAGS_SUPPORT >> source "lib/Kconfig.debug" >> >> config EARLY_PRINTK >> - bool "Early printk" if EMBEDDED >> + bool "Early printk" >> depends on SYS_HAS_EARLY_PRINTK >> - default y >> + default y if EMBEDDED > > I hate to be a pedant, but how about if we don't make it depend on > EMBEDDED at all? I.E. just: 'default y' > > If the system has SYS_HAS_EARLY_PRINTK, the overhead of enabling > EARLY_PRINTK is low, although it may slow down booting. But it is > really not at all related to EMBEDDED. Yeah, we should remove this dependency eventually, will send a new revision later. Thanks & Regards, Wu Zhangjin > > David Daney > > >> help >> This option enables special console drivers which allow the kernel >> to print messages very early in the bootup process. > >
