On Wed, Sep 22, 2010 at 18:44, David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote:
> On 09/21/2010 10:59 PM, wuzhangjin@xxxxxxxxx wrote:
>>
>> From: Wu Zhangjin<wuzhangjin@xxxxxxxxx>
>>
>> When EMBEDDED is disabled, the EARLY_PRINTK option will be hiden and we
>> have no way to disable it.
>>
>> For EARLY_PRINTK is not necessary for !EMBEDDED, we should make it
>> selectable and only enable it by default for EMBEDDED.
>>
>> Signed-off-by: Wu Zhangjin<wuzhangjin@xxxxxxxxx>
>> ---
>> Âarch/mips/Kconfig.debug | Â Â4 ++--
>> Â1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
>> index 43dc279..77eba81 100644
>> --- a/arch/mips/Kconfig.debug
>> +++ b/arch/mips/Kconfig.debug
>> @@ -7,9 +7,9 @@ config TRACE_IRQFLAGS_SUPPORT
>> Âsource "lib/Kconfig.debug"
>>
>> Âconfig EARLY_PRINTK
>> - Â Â Â bool "Early printk" if EMBEDDED
>> + Â Â Â bool "Early printk"
>> Â Â Â Âdepends on SYS_HAS_EARLY_PRINTK
>> - Â Â Â default y
>> + Â Â Â default y if EMBEDDED
>
> I hate to be a pedant, but how about if we don't make it depend on EMBEDDED
> at all? ÂI.E. just: 'default y'
That's what it was.
> If the system has SYS_HAS_EARLY_PRINTK, the overhead of enabling
> EARLY_PRINTK is low, although it may slow down booting. ÂBut it is really
> not at all related to EMBEDDED.
Originally, not the _value_ of EARLY_PRINTK depended on EMBEDDED,
but the option to _change_ the value.
Gr{oetje,eeting}s,
            Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
