On Sun, Aug 08, 2010 at 10:15:04PM -0700, David Daney wrote: > On 08/08/2010 12:57 PM, Namhyung Kim wrote: > >remove unneccessary use of RELOC_HIDE(). It does simple addition of ptr and > >offset and in this case (offset 0) does practically nothing. It does NOT do > >anything with linker relocation. > > > > Maybe you could explain in more detail the problems you are having > with the current definition of __pa_symbol(). I would be hesitant > to change this bit of black magic unless there is a concrete problem > you are trying to solve. RELOC_HIDE was originally added by 6007b903dfe5f1d13e0c711ac2894bdd4a61b1ad (lmo) rsp. 8431fd094d625b94d364fe393076ccef88e6ce18 (kernel.org). A discussion can be found in lkml posting a2ebde260608230500o3407b108hc03debb9da6e62c@xxxxxxxxxxxxxx> which is archived at http://lists.linuxcoding.com/kernel/2006-q3/msg17360.html I felt this was dubious by the time it was added and probably should go? Ralf