Hi David, Ralf, > The OCTEON is a MIPS64 based SOC family with an on chip watchdog unit. > > The driver is split into two source files one for the C code and one > for assembly. Assembly is needed to handle the NMI and then print the > machine state before the reboot is triggered. > > v2: Stylistic changes suggested by Sam Ravnborg. This v2 looks good. only small remark is: > +static struct notifier_block octeon_wdt_cpu_notifier = { > + .notifier_call = octeon_wdt_cpu_callback > +}; Add a comma after octeon_wdt_cpu_callback. > Signed-off-by: David Daney <ddaney@xxxxxxxxxxxxxxxxxx> > Cc: Wim Van Sebroeck <wim@xxxxxxxxx> Signed-off-by: Wim Van Sebroeck <wim@xxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > Cc: Marc Zyngier <maz@xxxxxxxxxxxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> Kind regards, Wim.