-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Andrew Morton wrote: > On Thu, 15 Jul 2010 23:06:04 +0200 > Lars-Peter Clausen <lars@xxxxxxxxxx> wrote: > >> This patch adds support for the mmc controller on JZ4740 SoCs. >> >> >> ... >> >> + if (gpio_is_valid(host->pdata->gpio_power)) >> + gpio_set_value(host->pdata->gpio_power, >> + !host->pdata->power_active_low); >> >> ... >> > > Should this driver have a `depends on GPIOLIB' in Kconfig? > The driver depends on MACH_JZ4740 which selects ARCH_REQUIRE_GPIOLIB, so there already is an implicit depends on GPIOLIB. - - Lars -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEUEARECAAYFAkw/f60ACgkQBX4mSR26RiNexQCfUXt0cqiMqEf17k+z+q6XVwRO ImEAmPKxeyX9ANVasUNL60f51GxKofg= =3NrE -----END PGP SIGNATURE-----