On Mon, 28 Jun 2010, Ralf Baechle wrote: > > > CONFIG_SIBYTE_BCM1480_PROF doesn't exist in Kconfig, therefore removing all > > > references for it from the source code. > > > > The patch isn't present in linux-next as of today. I have applied it to my > > tree, thanks. > > Nack. This only need to be rewired to use the ZBus profiler just like > the SB1250 already does. It's the virtually same hardware after all! Well, still it's dead code guarded by ifdef depending on non-exsiting symbol ... I have just quickly tried to get a grip on the zbus thing, but arch/mips/configs/bigsur_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y arch/mips/configs/sb1250-swarm_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y 1arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING arch/mips/sibyte/Kconfig: select SIBYTE_HAS_ZBUS_PROFILING arch/mips/sibyte/Kconfig: depends on SIBYTE_HAS_ZBUS_PROFILING arch/mips/sibyte/Kconfig:config SIBYTE_HAS_ZBUS_PROFILING seem to be the only occurences in the whole tree. Another unused symbol? So I'll revert that patch in my tree as it has been nacked by maintainer, but the feeling that cleanup is needed is still there. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc.
