>> For we will use the save_perf_irq in the common function: >> mipspmu_get_irq() of the next patch, so, we need to move the definition >> of it out of the #if ... and put it before the #if: >> >> ... >> +static int (*save_perf_irq)(void); >> >> #if defined(CONFIG_CPU_MIPS32) >> ... > > oh, no, For Oprofile not use it, we can define it before > mipspmu_get_irq() directly. > Thanks for your comments! Just a correction: op_model_mipsxx.c will also use save_perf_irq. So when taking your 2nd solution, we need to define another static save_perf_irq in op_model_mipsxx.c.