Hi, On Wed, 2010-05-05 at 21:55 +0800, Deng-Cheng Zhu wrote: > Moving performance counter/control defines/helper functions into a single > header file, so that software using the MIPS PMU can share the code. > > Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@xxxxxxxxx> > --- > arch/mips/include/asm/pmu.h | 244 +++++++++++++++++++++++++++++++ > arch/mips/oprofile/op_model_loongson2.c | 23 +--- > arch/mips/oprofile/op_model_mipsxx.c | 164 +--------------------- > arch/mips/oprofile/op_model_rm9000.c | 16 +-- > 4 files changed, 247 insertions(+), 200 deletions(-) > create mode 100644 arch/mips/include/asm/pmu.h > > diff --git a/arch/mips/include/asm/pmu.h b/arch/mips/include/asm/pmu.h [...] > + > +#ifndef __MIPS_PMU_H__ > +#define __MIPS_PMU_H__ > + > +#if defined(CONFIG_CPU_MIPS32) || defined(CONFIG_CPU_MIPS64) || \ > + defined(CONFIG_CPU_R10000) || defined(CONFIG_CPU_SB1) [...] > +static int (*save_perf_irq)(void); For we will use the save_perf_irq in the common function: mipspmu_get_irq() of the next patch, so, we need to move the definition of it out of the #if ... and put it before the #if: ... +static int (*save_perf_irq)(void); #if defined(CONFIG_CPU_MIPS32) ... Regards, Wu Zhangjin
